fix: Add more RTL improvements #526
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. I think the text is not floating right: I think it should start from the right direction here: I'm not sure if this is the right file for this issue, but the navigator isn't quite right: For reference here's how it looks in LTR:
There was a problem hiding this comment. The There was a problem hiding this comment. Should changes to There was a problem hiding this comment. The |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,8 +39,8 @@ | |
| .results #result_list { | ||
| box-shadow: none; | ||
| .related-widget-wrapper a.change-related { | ||
| margin-inline-start: 5px; | ||
| margin-inline-end: 0; | ||
| } | ||
| } | ||
| #toolbartable .paginator { | ||
|
|
@@ -76,9 +76,9 @@ | |
| overflow-y: auto; | ||
| width: $filtered-filter-width !important; | ||
| max-height: 585px; | ||
| margin-inline-start: $filtered-filter-margin; | ||
| padding-inline-end: $filtered-filter-padding; | ||
| padding-inline-start: 0; | ||
|
|
||
| h2 { | ||
| letter-spacing: 0; | ||
|
|
@@ -98,11 +98,11 @@ | |
| .paginator { | ||
| // calculates correct width because of margin right | ||
| width: calc(100% - #{$filter-changelist-margin}) !important; | ||
| border-inline-end: 0; | ||
| box-shadow: $base-box-shadow; | ||
| } | ||
| .actions { | ||
| margin-inline-end: $filtered-filter-width !important; | ||
| } | ||
|
|
||
| .changelist-form-container { | ||
|
|
@@ -178,24 +178,30 @@ | |
| // makes sure that if admin cations are visible that toolbar floats to position next to actions #275, #285 | ||
| &.actions-visible { | ||
| float: left; | ||
| [dir="rtl"] & { | ||
| float: right; | ||
| } | ||
| margin-bottom: 5px !important; | ||
| } | ||
| } | ||
| #changelist-filter { | ||
| // resets position to float filter next to changelist | ||
| position: static; | ||
| float: right; | ||
| [dir="rtl"] & { | ||
| float: left; | ||
| } | ||
| min-height: 100%; | ||
| margin-top: 8px; | ||
| border-left: 0; | ||
| border-start-end-radius: $border-radius-base; | ||
| border-end-end-radius: $border-radius-base; | ||
| background-color: $gray-lightest !important; | ||
| h2, | ||
| h3 { | ||
| margin-bottom: 15px !important; | ||
| padding-bottom: 10px !important; | ||
| padding-inline-start: 0 !important; | ||
| border-bottom: solid 1px $gray-lighter; | ||
| } | ||
| h2 { | ||
|
|
@@ -215,8 +221,8 @@ | |
| ul { | ||
| font-size: $font-size-small; | ||
| margin-bottom: 10px; | ||
| margin-inline-start: 0 !important; | ||
| padding-inline-start: 0; | ||
| padding-bottom: 0; | ||
| border-bottom: none; | ||
| } | ||
|
|
@@ -225,9 +231,9 @@ | |
| margin-bottom: 15px; | ||
| &.selected { | ||
| font-weight: bold; | ||
| margin-inline-start: 0 !important; | ||
| padding-inline-start: 0 !important; | ||
| border-inline-start: 0 !important; | ||
| a { | ||
| color: $color-primary !important; | ||
| } | ||
|
|
@@ -245,7 +251,7 @@ | |
| width: 257px !important; | ||
| font-size: 12px; | ||
| margin-top: 3px; | ||
| margin-inline-end: 10px; | ||
| padding: 6px 40px 6px 20px; | ||
| border: 1px solid $gray-lighter; | ||
| border-radius: $border-radius-base; | ||
|
|
@@ -255,15 +261,15 @@ | |
| // make sure that only icon is displayed | ||
| font: 0/0 a; | ||
| margin-bottom: 0; | ||
| margin-inline-start: 0; | ||
| } | ||
| button { | ||
| font-family: $base-font-family; | ||
| font-size: $font-size-small; | ||
| vertical-align: bottom; | ||
| height: 36px; | ||
| margin-top: 0; | ||
| margin-inline-end: 10px; | ||
| margin-bottom: 0; | ||
| padding: 10px 15px !important; | ||
| box-shadow: none; | ||
|
|
@@ -286,14 +292,17 @@ | |
| li { | ||
| display: inline; | ||
| float: left; | ||
| [dir="rtl"] & { | ||
| float: right; | ||
| } | ||
| color: $gray-darkest; | ||
| font-size: $font-size-normal; | ||
| font-weight: normal; | ||
| text-transform: uppercase; | ||
| margin-inline-start: 25px; | ||
| cursor: pointer; | ||
| &:first-child { | ||
| margin-inline-start: 0; | ||
| } | ||
| } | ||
| a { | ||
|
|
@@ -327,7 +336,7 @@ | |
| vertical-align: middle; | ||
| margin-top: 2px; | ||
| // adds space between search field and checkbox #216 | ||
| margin-inline-start: 10px; | ||
| + label { | ||
| display: inline-block !important; | ||
| color: $gray-light !important; | ||
|
|
@@ -347,7 +356,7 @@ | |
| vertical-align: middle; | ||
| text-indent: -9999px; | ||
| box-sizing: border-box; | ||
| margin-inline-start: 10px !important; | ||
| padding: 10px 16px !important; | ||
| background-image: url("../img/[email protected]") !important; | ||
| background-repeat: no-repeat !important; | ||
|
|
@@ -373,21 +382,21 @@ | |
| text-transform: uppercase; | ||
| width: 175px; | ||
| margin-bottom: 5px; | ||
| padding-inline-start: 25px; | ||
| border-inline-start: 0; | ||
| background: url("../img/icon_arrow_down.png") no-repeat left center; | ||
| background-size: 25px; | ||
| + #changelist-filter { | ||
| position: absolute; | ||
| top: 30px; | ||
| margin-top: 1px; | ||
| padding-inline-start: 15px !important; | ||
| } | ||
| } | ||
| // select field when multiple sites are available #201 | ||
| #site-selector { | ||
| margin-top: -18px; | ||
| margin-inline-start: 0; | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -419,14 +428,17 @@ | |
| } | ||
| .text { | ||
| float: none; | ||
| padding-inline-end: 0; | ||
| a { | ||
| padding: 0 !important; | ||
| } | ||
| } | ||
| .sortoptions { | ||
| display: inline-block; | ||
| float: right; | ||
| [dir="rtl"] & { | ||
| float: left; | ||
| } | ||
| padding-top: 0; | ||
| a.sortremove { | ||
| &:after { | ||
|
|
@@ -455,7 +467,7 @@ a.lang-code { | |
| font-size: $font-size-small !important; | ||
| font-weight: bold !important; | ||
| text-transform: uppercase; | ||
| margin-inline-end: 10px !important; | ||
| padding: 2px 8px !important; | ||
| border: solid 1px $gray-lighter; | ||
| border-radius: 10px !important; | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon for
messagelistis hovering over the text