Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/better compatibility and update ci cd #57

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

vinitkumar
Copy link
Member

@vinitkumar vinitkumar commented Nov 22, 2024

Description

  • Remove outdated code.
  • Cleanup for Github actions and update some of the actions.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Enhance compatibility by removing outdated code and update CI workflows to use the latest versions of GitHub Actions and Python.

Enhancements:

  • Remove outdated code for better compatibility with newer Django versions.

CI:

  • Update GitHub Actions workflows to use newer versions of actions and Python.

These github actions has some outdated actions. This updates them to the
latest available . Also, Python3.12 is the standard now
@vinitkumar vinitkumar requested a review from fsbraun November 22, 2024 02:28
Copy link

sourcery-ai bot commented Nov 22, 2024

Reviewer's Guide by Sourcery

This PR focuses on updating CI/CD configurations and improving compatibility by updating GitHub Actions workflows and removing legacy Django compatibility code. The changes include updating action versions, adding Python 3.13 support, configuring Codecov token, and cleaning up deprecated Django 2.2 compatibility code.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update GitHub Actions workflow configurations
  • Update actions/checkout from v1/v3 to v4
  • Update actions/setup-python from v2/v4 to v5
  • Add Python 3.13 to test matrix
  • Update codecov-action to v5 and add token configuration
  • Improve YAML formatting and indentation
.github/workflows/test.yml
.github/workflows/publish-to-test-pypi.yml
.github/workflows/publish-to-live-pypi.yml
.github/workflows/lint.yml
Remove legacy Django compatibility code
  • Remove Django 2.2 specific code path
  • Simplify from_db_value method implementation
djangocms_attributes_field/fields.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@vinitkumar vinitkumar requested a review from marksweb November 22, 2024 02:29
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vinitkumar - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • from_db_value needs to return the result of _from_db_value (link)
Here's what I looked at during the review
  • 🔴 General issues: 1 blocking issue
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

djangocms_attributes_field/fields.py Show resolved Hide resolved
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base (73007eb) to head (b9c6bb9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   89.61%   90.36%   +0.75%     
==========================================
  Files           3        4       +1     
  Lines         154      166      +12     
  Branches       28       26       -2     
==========================================
+ Hits          138      150      +12     
  Misses         10       10              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

djangocms_attributes_field/fields.py Outdated Show resolved Hide resolved
@vinitkumar vinitkumar merged commit 47864a0 into master Nov 22, 2024
40 checks passed
@vinitkumar vinitkumar deleted the feat/better-compatibility-and-update-ci-cd branch November 22, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants