-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/better compatibility and update ci cd #57
Feat/better compatibility and update ci cd #57
Conversation
These github actions has some outdated actions. This updates them to the latest available . Also, Python3.12 is the standard now
Reviewer's Guide by SourceryThis PR focuses on updating CI/CD configurations and improving compatibility by updating GitHub Actions workflows and removing legacy Django compatibility code. The changes include updating action versions, adding Python 3.13 support, configuring Codecov token, and cleaning up deprecated Django 2.2 compatibility code. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vinitkumar - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- from_db_value needs to return the result of _from_db_value (link)
Here's what I looked at during the review
- 🔴 General issues: 1 blocking issue
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
==========================================
+ Coverage 89.61% 90.36% +0.75%
==========================================
Files 3 4 +1
Lines 154 166 +12
Branches 28 26 -2
==========================================
+ Hits 138 150 +12
Misses 10 10
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the context argument should go away? https://docs.djangoproject.com/en/3.0/releases/2.0/#features-deprecated-in-2-0
Description
Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.
Summary by Sourcery
Enhance compatibility by removing outdated code and update CI workflows to use the latest versions of GitHub Actions and Python.
Enhancements:
CI: