Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow empty icon (None) in icon tags #159

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Oct 23, 2023

No description provided.

@fsbraun fsbraun changed the title Fix: Allow empty icon (None) in icon tags fix: Allow empty icon (None) in icon tags Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6794a6e) 86.88% compared to head (5a69dd9) 86.88%.
Report is 1 commits behind head on master.

❗ Current head 5a69dd9 differs from pull request most recent head 06c4a59. Consider uploading reports for the commit 06c4a59 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   86.88%   86.88%           
=======================================
  Files         119      119           
  Lines        3089     3089           
  Branches      329      329           
=======================================
  Hits         2684     2684           
  Misses        299      299           
  Partials      106      106           
Files Coverage Δ
...ms_frontend/contrib/icon/templatetags/icon_tags.py 76.92% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun merged commit 5f82c14 into django-cms:master Oct 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant