-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.2.2 #287
Release 2.2.2 #287
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
==========================================
- Coverage 84.19% 79.28% -4.92%
==========================================
Files 23 40 +17
Lines 1740 1868 +128
Branches 282 213 -69
==========================================
+ Hits 1465 1481 +16
- Misses 245 355 +110
- Partials 30 32 +2 ☔ View full report in Codecov by Sentry. |
@joshyu I'm ready to go if you are. |
Reviewer's Guide by SourceryThis is a version bump release that updates the package version from 2.2.1 to 2.2.2. The changes include fixes for the WorkflowAdmin sorting functionality and toolbar collection button. Class diagram for WorkflowAdmin changesclassDiagram
class WorkflowAdmin {
-SortableAdminMixin
+SortableAdminBase
}
note for WorkflowAdmin "Replaced SortableAdminMixin with SortableAdminBase"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @joshyu - I've reviewed your changes - here's some feedback:
Overall Comments:
- The first checklist item about tests is unchecked - please ensure appropriate tests are added for the admin and toolbar changes
- The diff only shows version changes - please include the actual code changes for the SortableAdminMixin and toolbar button fixes
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@fsbraun , |
Description
Related resources
fix: Replace SortableAdminMixin by SortableAdminBase for WorkflowAdmin
fix: Restore "In Collection" button in the toolbar
Checklist
Summary by Sourcery
Release version 2.2.2 with bug fixes including replacing SortableAdminMixin with SortableAdminBase for WorkflowAdmin and restoring the 'In Collection' button in the toolbar.
Bug Fixes: