Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2.2 #287

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Release 2.2.2 #287

merged 6 commits into from
Dec 3, 2024

Conversation

joshyu
Copy link
Contributor

@joshyu joshyu commented Nov 7, 2024

Description

Related resources

fix: Replace SortableAdminMixin by SortableAdminBase for WorkflowAdmin
fix: Restore "In Collection" button in the toolbar

Checklist

Summary by Sourcery

Release version 2.2.2 with bug fixes including replacing SortableAdminMixin with SortableAdminBase for WorkflowAdmin and restoring the 'In Collection' button in the toolbar.

Bug Fixes:

  • Replace SortableAdminMixin with SortableAdminBase for WorkflowAdmin to fix sorting issues.
  • Restore the 'In Collection' button in the toolbar.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.28%. Comparing base (79aaae4) to head (231cdeb).
Report is 84 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   84.19%   79.28%   -4.92%     
==========================================
  Files          23       40      +17     
  Lines        1740     1868     +128     
  Branches      282      213      -69     
==========================================
+ Hits         1465     1481      +16     
- Misses        245      355     +110     
- Partials       30       32       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vipulnarang95
Copy link
Contributor

@fsbraun @joshyu Is this version released? if not there are my changes as well, which needs a release. Please confirm. Thanks Vipul

@fsbraun
Copy link
Member

fsbraun commented Nov 28, 2024

@joshyu I'm ready to go if you are.

@joshyu joshyu marked this pull request as ready for review December 3, 2024 06:26
Copy link
Contributor

sourcery-ai bot commented Dec 3, 2024

Reviewer's Guide by Sourcery

This is a version bump release that updates the package version from 2.2.1 to 2.2.2. The changes include fixes for the WorkflowAdmin sorting functionality and toolbar collection button.

Class diagram for WorkflowAdmin changes

classDiagram
    class WorkflowAdmin {
        -SortableAdminMixin
        +SortableAdminBase
    }
    note for WorkflowAdmin "Replaced SortableAdminMixin with SortableAdminBase"
Loading

File-Level Changes

Change Details Files
Version bump from 2.2.1 to 2.2.2
  • Updated version number in package initialization file
djangocms_moderation/__init__.py
Documentation update for version changes
  • Updated changelog to reflect new version changes
CHANGELOG.rst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joshyu - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The first checklist item about tests is unchecked - please ensure appropriate tests are added for the admin and toolbar changes
  • The diff only shows version changes - please include the actual code changes for the SortableAdminMixin and toolbar button fixes
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

CHANGELOG.rst Outdated Show resolved Hide resolved
@joshyu
Copy link
Contributor Author

joshyu commented Dec 3, 2024

@fsbraun ,
I'm fine, please help to merge it.

@fsbraun fsbraun merged commit 9b62ecd into django-cms:master Dec 3, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants