-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port-feat: pre-commit config added from the v3 workstream #117
Merged
Aiky30
merged 9 commits into
django-cms:support/django-cms-4.0.x
from
Aiky30:port/pre-commit-config-for-djangocms-4
May 10, 2022
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5e941d1
port-feat: pre-commit config added from the v3 worksream
Aiky30 ea70858
Fix typo int he changelog
Aiky30 e068a9d
Update .pre-commit-config.yaml
Aiky30 69b7284
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 17c1cdf
Update .pre-commit-config.yaml
Aiky30 abc3643
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5b12766
Update .pre-commit-config.yaml
Aiky30 184cf78
Undo a chnage i didn't make
Aiky30 c86568a
Remove precommit formatting script
Aiky30 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
repos: | ||
# Need to drop python 3.5 and 3.6 before we include python upgrade | ||
# - repo: https://github.com/asottile/pyupgrade | ||
# rev: v2.31.0 | ||
# hooks: | ||
# - id: pyupgrade | ||
# args: ["--py37-plus"] | ||
|
||
- repo: https://github.com/adamchainz/django-upgrade | ||
rev: '1.4.0' | ||
hooks: | ||
- id: django-upgrade | ||
args: [--target-version, "1.11"] | ||
Aiky30 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- repo: https://github.com/PyCQA/flake8 | ||
rev: 4.0.1 | ||
hooks: | ||
- id: flake8 | ||
|
||
- repo: https://github.com/asottile/yesqa | ||
rev: v1.3.0 | ||
hooks: | ||
- id: yesqa | ||
|
||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v4.1.0 | ||
hooks: | ||
- id: check-merge-conflict | ||
- id: mixed-line-ending | ||
|
||
- repo: https://github.com/pycqa/isort | ||
rev: 5.10.1 | ||
hooks: | ||
- id: isort |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While django 1.11 is supported this hook should be excluded as it's minimum version is 2.2;
https://github.com/adamchainz/django-upgrade#usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed via a GH suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the hook to 2.2 breaks the code because it makes it django 2.2 compatible. You are going to get a lot of complaints as this is added to more projects, especially when enterprise is behind always.