Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Include hidden files in artifact build #175

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

mrbazzan
Copy link
Contributor

@mrbazzan mrbazzan commented Jan 18, 2025

Description

Fix CI failure

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #pr-review on
    Discord to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

CI:

  • Upload hidden coverage files as artifacts.

Copy link
Contributor

sourcery-ai bot commented Jan 18, 2025

Reviewer's Guide by Sourcery

This pull request modifies the CI workflow to include hidden files in the artifact build. This change ensures that all coverage data files are included in the artifact, which is necessary for the CI to pass.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
The CI workflow was modified to include hidden files in the artifact build.
  • Added the 'include-hidden-files: true' option to the 'actions/upload-artifact@v4' action.
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mrbazzan - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide more context in the PR description about what CI failure this is fixing and why including hidden files resolves the issue. This will help future maintainers understand the reasoning behind this change.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mrbazzan mrbazzan force-pushed the fix-codecov-failure branch from 44b4fd8 to 072a0d1 Compare January 18, 2025 00:56
@mrbazzan
Copy link
Contributor Author

@fsbraun
Passes. Ready for review

@fsbraun fsbraun merged commit 62bb317 into django-cms:master Jan 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants