fix: Editing of existing snippet not allows (unversioned snippets)

[fsbraun]

Description

Fix for #176

Related resources

• Updating an existing Snippet results in invalid error message #176
• #...

Checklist

• I have opened this pull request against master
• I have added or modified the tests when changing logic
• I have followed the conventional commits guidelines to add meaningful information into the changelog
• I have read the contribution guidelines and I have joined #pr-review on
  Discord to find a “pr review buddy” who is
  going to review my pull request.

Summary by Sourcery

Bug Fixes:

• Fix an issue that prevented editing existing snippets if they were not versioned.

[sourcery-ai]

Reviewer's Guide by Sourcery

The pull request fixes a bug where editing an existing snippet was not allowed when versioning was enabled. The fix involves modifying the queryset to exclude snippets with the same snippet_grouper, regardless of whether versioning is enabled or not.

Sequence diagram for snippet validation flow

sequenceDiagram
    participant User
    participant Form as SnippetForm
    participant DB as Database

    User->>Form: Submit snippet edit
    Form->>Form: clean()
    Form->>DB: Query snippets
    Note over Form,DB: Exclude snippets with same grouper
    DB-->>Form: Return filtered snippets
    Form->>Form: Check for duplicate names
    alt Duplicate name exists
        Form-->>User: Validation error
    else Name is unique
        Form-->>User: Validation passes
    end

Loading

Class diagram for snippet form changes

classDiagram
    class SnippetForm {
        +clean()
    }
    class Snippet {
        +name: str
        +slug: str
        +snippet_grouper: ForeignKey
    }
    SnippetForm ..> Snippet: validates
    note for SnippetForm "Modified clean() to always exclude
snippets with same grouper"

Loading

File-Level Changes

Change	Details	Files
Modified the queryset to exclude snippets with the same snippet_grouper.	Removed the conditional logic that checked if versioning was enabled. Modified the queryset to always exclude snippets with the same snippet_grouper.	src/djangocms_snippet/forms.py

Possibly linked issues

• Updating an existing Snippet results in invalid error message #176: The PR fixes the issue by changing the clean method to exclude the current snippet from the check.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.