-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support djangocms-picture 2.0.0 and higher in create_picture_plugin #660
Conversation
…elper. djangocms-picture 2.0.0 switched to a filer reference to store the image so the helper must create a filer image instance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #660 +/- ##
==========================================
+ Coverage 76.36% 81.79% +5.43%
==========================================
Files 20 20
Lines 918 912 -6
Branches 123 122 -1
==========================================
+ Hits 701 746 +45
+ Misses 191 138 -53
- Partials 26 28 +2 ☔ View full report in Codecov by Sentry. |
@leture Do you think you can cover this in a test? |
…the helper create_picture_plugin
@fsbraun Because of the lack of an existing test to just adjust I wrote a test for the helper |
…tion because django-cms 4.1 is needs Python>=3.8
… conditional import of the picture plugin
@fsbraun I am finished here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Looks good to me. I have just a minor recommendation. Thank you so much, @leture!
djangocms-picture 2.0.0 switched to a filer reference to store the image so the helper must create a filer image instance
Refs #642