-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created custom django_cms serializer to be able to handle django cms … #24
base: master
Are you sure you want to change the base?
Conversation
…o cms filer images
super(Serializer, self).handle_fk_field(obj, field) | ||
|
||
|
||
def Deserializer(object_list, **options): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pep8: this should be lowercase if it's a function, however, it appears that you might have meant this to be a class with a deserialize method??? It seems by the name that is should be a class with maybe a static method. Anyway, just a nitpick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I can change it to lowercase. It was inspired by Django python serializer itself https://github.com/django/django/blob/main/django/core/serializers/python.py#L88
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it needs to be uppercase https://github.com/django/django/blob/0dd29209091280ccf34e07c9468746c396b7778e/django/core/serializers/__init__.py#L125
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robert-foreflight what do you think about that ?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
- Coverage 31.83% 28.20% -3.63%
==========================================
Files 11 12 +1
Lines 377 429 +52
Branches 63 70 +7
==========================================
+ Hits 120 121 +1
- Misses 257 308 +51 ☔ View full report in Codecov by Sentry. |
…o cms filer images
@robert-foreflight Can you check this out? |
This might be resolved with the changes from #20. |
…filer images
Description
Added ability to define own serializer based on #14 and created serializers folder where is created new django_cms serializer which is able to transfer djangocms filer image as base64 string.
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.