Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for django 4.2 and python 3.10, drop support for django 2… #86

Conversation

FreemanPancake
Copy link
Contributor

  • Add support for Django 4.2, now supports Django [3.2, 4.2]
  • Add support for Python 3.10, now supports Python [3.8, 3.9, 3.10]
  • Drop support for Django 2.x
  • Drop support for Python 3.6 & 3.7

@joshyu
Copy link
Contributor

joshyu commented Mar 12, 2024

@Aiky30 / @fsbraun please help to review.
I find that the workflow need maintainer's approval and then can run.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (support/4.0.x@a98d71a). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             support/4.0.x      #86   +/-   ##
================================================
  Coverage                 ?   77.76%           
================================================
  Files                    ?       30           
  Lines                    ?      778           
  Branches                 ?       76           
================================================
  Hits                     ?      605           
  Misses                   ?      153           
  Partials                 ?       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun
Copy link
Member

fsbraun commented Mar 12, 2024

@FreemanPancake @joshyu Can you please reopen this PR against master? djangocms-url-manager is fully compatible with django CMS 4.0. The difference of the master branch is, that django 2.2 support already had been removed. We can keep one code base.

@joshyu
Copy link
Contributor

joshyu commented Mar 13, 2024

@FreemanPancake @joshyu Can you please reopen this PR against master? djangocms-url-manager is fully compatible with django CMS 4.0. The difference of the master branch is, that django 2.2 support already had been removed. We can keep one code base.

@fsbraun ,
Thanks for your confirmation about our work. That makes sense, we will raise another PR based on master branch.

@fsbraun
Copy link
Member

fsbraun commented Mar 14, 2024

Superseeded by #87

@fsbraun fsbraun closed this Mar 14, 2024
@FreemanPancake FreemanPancake deleted the feat/django-42-compat branch April 23, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants