-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds a link to published content #272
Open
marksweb
wants to merge
18
commits into
django-cms:master
Choose a base branch
from
marksweb:feat/published-action
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
624ebef
Added action button to view the published content
marksweb 069ed80
Add an extra line of defence
marksweb d14ba68
Correct template path
marksweb 3aad6e4
Fix tox
marksweb 23bf3e8
Added tests for new published content link
marksweb 62fad31
Improvements following testing
marksweb 2ee579e
Updated changelog
marksweb c2cb8aa
Remove from ``ExtendedVersionAdminMixin``
marksweb ec21999
Merge branch 'master' into feat/published-action
marksweb c77cb09
Merge branch 'master' into feat/published-action
marksweb 225f9a4
Extend ignored directories for isort and flake8
marksweb 6d02e4b
Addressed review comments
marksweb f993621
Fix path to template
marksweb 094a1bb
Update test expectation following template change.
marksweb 093613b
Update test expectation following template change.
marksweb 4c144af
Expect an ``AttributeError`` when object isn't versioning compatible
marksweb e2c8b40
Allow for versioned objects w/o .get_absolute_url
fsbraun 2d6dfc8
Merge branch 'master' into feat/published-action
fsbraun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
djangocms_versioning/templates/djangocms_versioning/admin/icons/published_icon.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{% extends "./base.html" %} | ||
{% load static i18n %} | ||
{% block title %}{% trans 'View published' %}{% endblock %} | ||
{% block name %}view published{% endblock %} | ||
{% block icon %}{% static 'djangocms_versioning/svg/preview.svg' %}{% endblock %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this because I thought that the isort and flake8 deps needed it, obviously not so no issues removing this.