Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes of styling, add codehilite, change datalink modal #255

Merged
merged 6 commits into from
Jan 27, 2025

Conversation

kimakan
Copy link
Contributor

@kimakan kimakan commented Jan 22, 2025

This PR adds following changes:

  • minor changes in styling, e.g., styling of the table in the metadata of a schema
  • a number of minor fixes, like fix of an mysql adapter ( it fixed also the ci tests) or rendering of the filepath in the results table
  • added codehilite for the rendering of the code in the markdown files
  • Major overhaul of the datalink modal. I simplified it quiet a bit for the user. We will provide links only for the previews (if exist), downloadable files (if exist) and all image previes with the semantic #preview-image or #preview-plot. If the user wants something else then there will be a link that leads to the full datalink viewer.
    So...now it looks something like this

image

@kimakan kimakan requested a review from jochenklar January 22, 2025 14:34
@coveralls
Copy link

coveralls commented Jan 22, 2025

Pull Request Test Coverage Report for Build 12984621735

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on style-minor-fixes at 64.428%

Totals Coverage Status
Change from base Build 12884297015: 64.4%
Covered Lines: 4994
Relevant Lines: 7189

💛 - Coveralls

@kimakan kimakan self-assigned this Jan 27, 2025
Copy link
Member

@jochenklar jochenklar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have some minor suggestions regarding JS syntactic sugar and I guess styling is always a bit about taste.

@kimakan kimakan merged commit cc82a7d into dev Jan 27, 2025
10 checks passed
@kimakan kimakan deleted the style-minor-fixes branch January 27, 2025 14:18
kimakan added a commit that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants