Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Python 3.12 support #1185

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Added Python 3.12 support #1185

merged 3 commits into from
Nov 20, 2023

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Oct 19, 2023

Description of the Change

Added support for Python 3.12.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc
Copy link
Member Author

sliverc commented Oct 19, 2023

Currently, not mergable because of an issue with django polymorphic see jazzband/django-polymorphic#541

@sliverc sliverc requested a review from n2ygk November 20, 2023 16:57
@sliverc
Copy link
Member Author

sliverc commented Nov 20, 2023

@n2ygk
Changes to support Python 3.12 have been merged in polymorphic, However I do not think a version will be released soon there.

Therefore, I temporarily set the requirement pointing to master branch of django polymorphic. This way, we are not getting blocked with adding Python 3.12 support. Once a new polymorphic version has been released, we can then pin it again.

Ready for review.

@n2ygk n2ygk merged commit 027e44c into django-json-api:main Nov 20, 2023
11 checks passed
@sliverc sliverc deleted the python_3_12 branch November 20, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants