-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed support for Python 3.8 #1266
Conversation
drfmaster tests are throwing an error for TypeError for encode of None. Maybe related to #1229? |
There is an upstream change in DRF which caused these errors. I have submitted a PR here encode/django-rest-framework#9615 hope it will be merged soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. getting-started.md needs also to be adjusted I think and also add a note in changelog to version 7.1.0 that states that it is the last version supporting 3.7. See how we did it in #1178
Done. Also, perhaps as a separate PR, should we make a failed drfmaster test a non-fatal workflow error? That's how we do it in DOT, for example: https://github.com/jazzband/django-oauth-toolkit/blob/master/tox.ini#L57-L59. Right now, errors in non-released DRF are blocking successful PRs here. |
See #1267 |
Thanks looks good. |
Description of the Change
Remove Python 3.8 which is EOL per PEP 569
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS