Split requirements files up following DRF example #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sliverc
force-pushed
the
requirements_files
branch
from
890870b to
63b1834
Compare
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
=======================================
Coverage 97.08% 97.08%
=======================================
Files 54 54
Lines 2742 2742
=======================================
Hits 2662 2662
Misses 80 80Continue to review full report at Codecov.
|
sliverc
force-pushed
the
requirements_files
branch
from
63b1834 to
aa8c06a
Compare
|
@sliverc Can you figure out why the sphinx build is failing? I've been staring at it and don't see why it shoud. |
|
@n2ygk |
sliverc
force-pushed
the
requirements_files
branch
from
fe8cf34 to
911a3b9
Compare
Fixes django-json-api#712 Fixes django-json-api#635 This way not all dependency need to be installed for the different testing steps.
sliverc
force-pushed
the
requirements_files
branch
from
911a3b9 to
ed10e03
Compare
sliverc
added a commit
to sliverc/django-rest-framework-json-api
that referenced
this pull request
Oct 3, 2021
Fixes django-json-api#518 Fixes django-json-api#720 This is to avoid an incomprehensible exception during runtime when either meta or results is used as a field name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #712
Fixes #635
Description of the Change
This way not all dependencies need to be installed for the different testing steps.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS