Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from pip-tools -> poetry #87

Merged
merged 7 commits into from
Oct 10, 2024
Merged

Move from pip-tools -> poetry #87

merged 7 commits into from
Oct 10, 2024

Conversation

bulya
Copy link
Collaborator

@bulya bulya commented Oct 8, 2024

What's changed?

  • Move from pip-tools to poetry; 💪
    • we are using the last one in the generated project, so there is no reason to use pip-tools in the skeleton.
  • Clean up skeleton's (not project) docker-compose-local.yml and related invoke tasks; 🧹
  • Clean up pip-tools's realated invoke tasks; 🧹
  • Update to Github actions to use poetry as a dependency manager + caching venv 🐎
  • Move pytest.ini -> pyproject.toml to have a single config file for several tools 💪

Also, this PR fixes the dependabot security issue https://github.com/django-stars/backend-skeleton/security/dependabot/30 as we can unpin and use the latest Pyyaml version.

bulya added 4 commits October 8, 2024 11:42
- Cleans up obsolete files, e.g. docker-compose.local
- Cleans up obsolete invoke tasks docker-compose & pip-tools
- Move pytest.ini -> pyproject.toml
- Improve GAs with using poetry
Copy link
Collaborator

@denys-chura denys-chura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 👍

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@bulya
Copy link
Collaborator Author

bulya commented Oct 9, 2024

The PR has been updated with Python 3.13 and non package mode for poetry.

.github/workflows/default.yml Show resolved Hide resolved
.github/workflows/default.yml Outdated Show resolved Hide resolved
.github/workflows/default.yml Outdated Show resolved Hide resolved
.github/workflows/default.yml Outdated Show resolved Hide resolved
.github/workflows/default.yml Outdated Show resolved Hide resolved
.github/workflows/default.yml Outdated Show resolved Hide resolved
@bulya bulya requested a review from denys-chura October 9, 2024 09:13
Copy link
Collaborator

@denys-chura denys-chura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bulya bulya merged commit 90f89ae into django-stars:main Oct 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants