[DI-2712] Some minor improvements #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add localhost and 0.0.0.0 to `*_ALLOWED_HOSTS`; - Add `*_DJANGO_ADMIN_URL` and `ADMIN_URL` to be able to change admin url; - Improve readme; - Fix `ConfirmResetPasswordSerializer.signature` field length validation; - Update `CELERY_TIMEZONE` to be set from `*_TIME_ZONE` environment variable instead of importing `django.py` settings file.
denys-chura
commented
Oct 22, 2024
| @@ -45,7 +45,7 @@ def save(self, **kwargs): | |||
|
|
|||
| class ConfirmResetPasswordSerializer(serializers.Serializer): | |||
| password = serializers.CharField(max_length=128, write_only=True, style={"input_type": "password"}) | |||
| signature = serializers.CharField(max_length=71, write_only=True) | |||
| signature = serializers.CharField(max_length=128, write_only=True) | |||
There was a problem hiding this comment.
Exact value for current configuration is 87 but then we will have no margin. I as I understand length of signature can be different if we change algorithm so I decide give it some margin.
denys-chura
commented
Oct 22, 2024
| @@ -12,6 +12,7 @@ | |||
| {{ cookiecutter.__env_prefix }}EMAIL_PORT=1025 | |||
| {{ cookiecutter.__env_prefix }}EMAIL_USE_TLS=off | |||
|
|
|||
| {{ cookiecutter.__env_prefix }}DJANGO_ADMIN_URL=admin/ | |||
There was a problem hiding this comment.
I open for suggestion to replace default admin/
alexryabtsev
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*_ALLOWED_HOSTS;*_DJANGO_ADMIN_URLandADMIN_URLto be able to change admin url;ConfirmResetPasswordSerializer.signaturefield length validation;CELERY_TIMEZONEto be set from*_TIME_ZONEenvironment variable instead of importingdjango.pysettings file.