Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for Django 4.1 and Python 3.10 #332

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

browniebroke
Copy link
Contributor

Djangop 4.1 has been released for a bit now. Add it to the build matrix and declare supprot for it.

@browniebroke browniebroke changed the title Add compatibility for Django 4.1 Add compatibility for Django 4.1 and Python 3.10 Dec 6, 2022
@browniebroke browniebroke changed the title Add compatibility for Django 4.1 and Python 3.10 Add compatibility for Django 4.1 and Python 3.10 Dec 6, 2022
@browniebroke browniebroke marked this pull request as draft December 6, 2022 16:08
@browniebroke browniebroke marked this pull request as ready for review December 6, 2022 16:17
@browniebroke
Copy link
Contributor Author

browniebroke commented Dec 6, 2022

I tried to add Python 3.11 but apprently there is no image. It seems like these are now deprecated, which would explain why 3.11 doesn't have any:

Legacy images with the prefix “circleci/” were deprecated on December 31, 2021. For faster builds, upgrade your projects with next-generation convenience images.

Comment on lines +109 to +112
if [ "$COVERALLS_REPO_TOKEN" != "" ]
then
coveralls
fi
Copy link
Contributor Author

@browniebroke browniebroke Dec 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To work around #292

Not an ideal fix, feel free to remove if you have a better idea

@fjsj
Copy link
Member

fjsj commented Dec 8, 2022

LGTM, thanks.

@fjsj fjsj merged commit 292c276 into django-webpack:master Dec 8, 2022
@browniebroke browniebroke deleted the upgrade/django-4.1 branch December 8, 2022 18:45
@fjsj
Copy link
Member

fjsj commented Dec 12, 2022

@browniebroke released at 1.8.0: https://github.com/django-webpack/django-webpack-loader/releases/tag/1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants