Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claiming DeFI Spring rewards #102

Closed
djeck1432 opened this issue Oct 25, 2024 · 10 comments · Fixed by #118
Closed

Claiming DeFI Spring rewards #102

djeck1432 opened this issue Oct 25, 2024 · 10 comments · Fixed by #118
Assignees
Labels

Comments

@djeck1432
Copy link
Owner

We need to add a new functionality for claiming accumulated DeFI Spring rewards and then transferring them to some account for further processing. Information about issue is built from gathered info, so extra research may be needed.

Steps:

  1. Read guidelines.
  2. Add the new method claim_rewards(claims, proofs) to the Deposit smart contract
  3. Check that position is open.
  4. Claim all rewards one by one and transfer them to some address (any will do for now).
  5. Test the code in the test_loop.cairo file

Definition of done:
Code is tested and works properly.

Please, apply only if you have already done at least a few tasks in Caior, also when you apply, attach some link reference of cairo code.

@SoarinSkySagar
Copy link
Contributor

SoarinSkySagar commented Oct 25, 2024

I like orange
I will first write the function definition in interface.cairo then implement the function in deposit.cairo, where the rewards will be transferred to a dummy address (eg.: 0xfffff...) one by one. will also write test functions and make sure everything passes

link of previous cairo task: NoshonNetworks/landver#99

@shubha-me
Copy link

I'd like to try this as a first issue.

@djeck1432
Copy link
Owner Author

I'd like to try this as a first issue.

Please do next things:

  1. Read guideline
  2. Add references

@djeck1432
Copy link
Owner Author

I like orange I will first write the function definition in interface.cairo then implement the function in deposit.cairo, where the rewards will be transferred to a dummy address (eg.: 0xfffff...) one by one. will also write test functions and make sure everything passes

link of previous cairo task: NoshonNetworks/landver#99

@SoarinSkySagar please, apply via OnlyDust platform

@ikemHood
Copy link
Contributor

ikemHood commented Oct 25, 2024

Hey @djeck1432, I’d like to help with this. I like Orange.

I would, write the fn
write the test

@djeck1432
Copy link
Owner Author

@ikemHood Please, send me references , apply via OnlyDust platform

@ikemHood
Copy link
Contributor

@ikemHood Please, send me references , apply via OnlyDust platform

Application was made through onlydust

@ikemHood
Copy link
Contributor

@SoarinSkySagar
Copy link
Contributor

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

gm @djeck1432, I am Sagar Rana and a smart contract developer and I have been building on Cairo for the past few months and I am pretty confident about it. I have attached a reference link below as you said and hopefully I will be able to work on this issue.

How I plan on tackling this issue

I like orange
I will first write the function definition in interface.cairo then implement the function in deposit.cairo, where the rewards will be transferred to a dummy address (eg.: 0xfffff...) one by one. will also write test functions and make sure everything passes

link of previous cairo task: NoshonNetworks/landver#99

ETA: 1 Day (2 at most; draft PR will be made within 24 hours of being assigned)

@mimisavage
Copy link
Contributor

I want to take on this issue, can I be assigned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment