Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: function claim_rewards for claiming DeFi Spring rewards #118

Merged
merged 25 commits into from
Oct 29, 2024
Merged

feat: function claim_rewards for claiming DeFi Spring rewards #118

merged 25 commits into from
Oct 29, 2024

Conversation

SoarinSkySagar
Copy link
Contributor

@SoarinSkySagar SoarinSkySagar commented Oct 26, 2024 •
edited
Loading

Closes #102

  • Created ClaimData struct
  • Written claim_rewards function
    • Checking if position is open
    • Claim all rewards one by one and transfer them to some address
  • Written test for claim_rewards

Tests Running

image

AndriiBogomolov and others added 20 commits October 26, 2024 19:58
@AndriiBogomolov @SoarinSkySagar
dashboard-API-fixing
b72e56a 
Dashboard-API-fixing
@AndriiBogomolov @SoarinSkySagar
dashboard backendUrl update
28ae2cc 
dashboard backendUrl update
@AndriiBogomolov @SoarinSkySagar
feat/added plug to dashboard
138ca25 
Added plug to dashboard in case of missing API data
@UzNaZ @SoarinSkySagar
added missing response models
25c58e4
@UzNaZ @SoarinSkySagar
fixed alembic
de7c7a0
@vitaliypopel @SoarinSkySagar
Created tests direcotry in web_app, created test_user.py file inside …
619a174 
…and made draft tests
@vitaliypopel @SoarinSkySagar
Fixed draft tests
8bbd9bd
@vitaliypopel @SoarinSkySagar
Created pytest.ini file
cf45f81
@vitaliypopel @SoarinSkySagar
Fixed draft tests
b2cd1c4
@vitaliypopel @SoarinSkySagar
Removed print debuger
8423f7d
@vitaliypopel @SoarinSkySagar
Created working tests
ff59022
@vitaliypopel @SoarinSkySagar
Added pytest, pytest-asyncio and httpx
437deb9
@vitaliypopel @SoarinSkySagar
Replaced response.status_code == 200 to response.is_success
f446cd0
@SoarinSkySagar
merge with audit-preparation
ff16906
@SoarinSkySagar
dependency error fix
7765235
@SoarinSkySagar
fix conflicts
d05c6b6
@SoarinSkySagar
fix conflict
c9ab4c3
@SoarinSkySagar
fix
b2db2a7
@SoarinSkySagar
fix conflict
9c5f9dd
@SoarinSkySagar
merge conflict
06c1ed4
@djeck1432 djeck1432 linked an issue Oct 26, 2024 that may be closed by this pull request
Claiming DeFI Spring rewards #102
Closed
@SoarinSkySagar SoarinSkySagar marked this pull request as ready for review October 27, 2024 22:28
faurdent
faurdent requested changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@faurdent faurdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes required, mostly looks good

src/deposit.cairo Outdated Show resolved Hide resolved
src/deposit.cairo Outdated Show resolved Hide resolved
src/deposit.cairo Outdated Show resolved Hide resolved
src/interfaces.cairo Show resolved Hide resolved
src/types.cairo Outdated Show resolved Hide resolved
src/deposit.cairo Outdated Show resolved Hide resolved
tests/test_loop.cairo Outdated Show resolved Hide resolved
faurdent
faurdent approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@faurdent faurdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeck1432 LGTM, approved

djeck1432
djeck1432 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432 djeck1432 merged commit 351caf8 into djeck1432:fix/audit-preparation Oct 29, 2024
@SoarinSkySagar
Copy link
Contributor Author

thank you @djeck1432 and @faurdent, would love to contribute to spotnet again 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeck1432 djeck1432 djeck1432 approved these changes

@faurdent faurdent faurdent approved these changes

Assignees

@SoarinSkySagar SoarinSkySagar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Claiming DeFI Spring rewards
6 participants
@SoarinSkySagar @djeck1432 @faurdent @AndriiBogomolov @UzNaZ @vitaliypopel