Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added frontend testing using Jest #103

Merged
merged 6 commits into from
Oct 26, 2024
Merged

Added frontend testing using Jest #103

merged 6 commits into from
Oct 26, 2024

Conversation

Dprof-in-tech
Copy link
Contributor

@Dprof-in-tech Dprof-in-tech commented Oct 25, 2024 •
edited
Loading

closes #91

Screenshot 2024-10-26 at 12 09 25

@whateverfw whateverfw self-requested a review October 26, 2024 10:50
@Dprof-in-tech Dprof-in-tech marked this pull request as ready for review October 26, 2024 11:08
whateverfw
whateverfw requested changes Oct 26, 2024
View reviewed changes
frontend/test/unit/transaction.test.js Outdated Show resolved Hide resolved
frontend/test/unit/contract.test.js Outdated Show resolved Hide resolved
frontend/test/unit/wallet.test.js Outdated Show resolved Hide resolved
frontend/test/unit/contract.test.js Outdated Show resolved Hide resolved
frontend/test/unit/wallet.test.js Outdated Show resolved Hide resolved
frontend/test/unit/wallet.test.js Outdated Show resolved Hide resolved
frontend/test/unit/transaction.test.js Outdated Show resolved Hide resolved
whateverfw
whateverfw requested changes Oct 26, 2024
View reviewed changes
Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit folder should be renamed to utils

@Dprof-in-tech
Copy link
Contributor Author

Dprof-in-tech commented Oct 26, 2024 via email

@whateverfw
Copy link
Collaborator

whateverfw commented Oct 26, 2024 •
edited
Loading

@Dprof-in-tech Please take a look into other comments above

@Dprof-in-tech
Copy link
Contributor Author

@Dprof-in-tech Please take a look into other comments above

i'm sorry i had seen the reviw in my mail, thought it was just one , ha ha

but its all fixed now

@djeck1432 djeck1432 self-requested a review October 26, 2024 20:39
djeck1432
djeck1432 approved these changes Oct 26, 2024
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432 djeck1432 merged commit 2a58305 into djeck1432:main Oct 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeck1432 djeck1432 djeck1432 approved these changes

@whateverfw whateverfw whateverfw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test cases for FE utils
3 participants
@Dprof-in-tech @whateverfw @djeck1432