Reworking Frontend Styles to Tailwind #500
Conversation
|
@djeck1432 Here I've made a draft pr for this issue #486 |
|
@michojekunle Please, finalize your task tomorrow, this task is critical and will block us |
|
@michojekunle any updates? |
Hi, I'm still on this currently |
…tion, DontMiss, and About sections
…mation, and Partnership components
There was a problem hiding this comment.
add cn utility composed with tailwind-merge and clsx (example reference: https://korayguler.medium.com/how-to-merge-react-and-tailwind-css-class-names-f5faeb10ed24) and use it for cases where styles should be applied conditionally or composed
|
@michojekunle Please sync with main and resolve merge conflicts, also resolve my comments and push your latest changes, we are planning to wrap up and finish this ticket tomorrow with changes that you'll able to finish by that time. |
…th Tailwind CSS for improved styling and responsiveness
…h improved styling and responsiveness
…hub.com/michojekunle/spotnet into feat/rework-frontend-styles-to-tailwind
|
@michojekunle just to be clear, did you finish and I can start to review? |
no, not yet, there are still some components I need to update |
ok, just let me know when you've finished everything that was planned |
There was a problem hiding this comment.
@michojekunle please make sure to remove old css files that are not used anymore
|
Please review |
There was a problem hiding this comment.
@michojekunle Currently there are styles mismatches on each page in terms of font sizes, font weight, font colors, card borders, paddings, etc., etc.
You should compare previous version with current one and make sure it looks exactly the same as before.
Alright, I'm already on this |
|
@michojekunle please resolve merge conflicts, also let me know when should I make next code review |
Alright sure, these conflicts are really much 🥲😂 I'm on it now |
mostly there are import differences, nothing much |
|
@michojekunle did you make merge correctly? |
yeah, I'm trying to fix an error now from the merge |
There was a change from CRA to Vite which I think was not implemented correctly and causing errors locally for me after merging, I'm trying to fix those errors now |
|
@michojekunle it was implemented correctly, at least I was able to run it locally myself and we run it in production currently (the only possible issue could be in-between tailwind/vite but I'm not sure what) |
…/rework-frontend-styles-to-tailwind
|
Hi @whateverfw I've resolved the merge conflicts |
There was a problem hiding this comment.
@michojekunle did you run the project?
also i see that in some places it was incorrectly merged (e.g. Documentation.jsx has duplicate keys in some objects)
|
@michojekunle sorry, there is still work left |
No description provided.