Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backend] add limit prams to possiton history endpoint #523

Merged
merged 5 commits into from
Jan 28, 2025
Merged

[Backend] add limit prams to possiton history endpoint #523

merged 5 commits into from
Jan 28, 2025

Conversation

Teri-anric
Copy link
Collaborator

No description provided.

@Teri-anric Teri-anric changed the title add limit prams to possiton history endpoint [Backend] add limit prams to possiton history endpoint Jan 28, 2025
@Teri-anric Teri-anric force-pushed the feat/add-limit-to-possition-history-endpoint branch from aa6bfcd to e36ac36 Compare January 28, 2025 13:48
@djeck1432 djeck1432 self-requested a review January 28, 2025 15:31
djeck1432
djeck1432 requested changes Jan 28, 2025
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see where you returned total positions number

@Teri-anric Teri-anric requested a review from djeck1432 January 28, 2025 16:55
djeck1432
djeck1432 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432 djeck1432 merged commit 09db61c into main Jan 28, 2025
7 checks passed
@djeck1432 djeck1432 deleted the feat/add-limit-to-possition-history-endpoint branch January 28, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeck1432 djeck1432 djeck1432 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Teri-anric @djeck1432