Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration tests add test by new flieds or refactory #554

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

Teri-anric
Copy link
Collaborator

@Teri-anric Teri-anric commented Feb 6, 2025

Fixes:

  • Updates the checkout action in the integration tests workflow to v4.
  • Modifies the return type annotation for get_positions_by_wallet_id in PositionDBConnector to list[dict].
  • Adds a method to delete all extra deposits for a position.
  • Implements integration tests for position creation, closing, liquidation, and extra deposits.
  • Adds a utility function for creating temporary users for testing.

This PR introduces integration tests for key functionalities: position creation, closing, liquidation, and extra deposits. It also includes a utility function for creating temporary users to ensure tests are isolated and do not interfere with each other. Additionally, a method to delete all extra deposits for a position was added.

@djeck1432 djeck1432 self-requested a review February 7, 2025 07:31
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432 djeck1432 merged commit 87d26b5 into djeck1432:main Feb 7, 2025
6 checks passed
@djeck1432 djeck1432 linked an issue Feb 7, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] Update integration test
2 participants