Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create endpoint for token multiplier #99

Merged
merged 9 commits into from
Oct 25, 2024
Merged

create endpoint for token multiplier #99

merged 9 commits into from
Oct 25, 2024

Conversation

od-hunter
Copy link
Contributor

@od-hunter od-hunter commented Oct 24, 2024 •
edited
Loading

Resolves #77
@djeck1432 Kindly review the endpoint created for token multiplier.

@djeck1432 djeck1432 self-requested a review October 24, 2024 19:52
djeck1432
djeck1432 requested changes Oct 24, 2024
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, great jobs, small issues and ready to merge

web_app/api/position.py Outdated Show resolved Hide resolved
djeck1432
djeck1432 reviewed Oct 24, 2024
View reviewed changes
web_app/api/position.py
class TokenMultiplierResponse(BaseModel):
multipliers: dict[str, float]

class Config:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add docstring

@od-hunter
Copy link
Contributor Author

@djeck1432 , please review

@djeck1432
Copy link
Owner

@od-hunter Please, fix pylint issues

@od-hunter
Copy link
Contributor Author

@djeck1432 please review

djeck1432
djeck1432 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Approved

@djeck1432 djeck1432 merged commit d08ed80 into djeck1432:main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeck1432 djeck1432 djeck1432 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create endpoint for fetching mulitpier per token
2 participants
@od-hunter @djeck1432