Make attractors regular modifiers #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the built-in code and shader handling a fixed-size array of force field attractors/repulsors, and related types `ForceFieldSource` and `ForceFieldModifier`. Replace them with a new `ConformToSphereModifier` describing a single attractor/repulsor source, which can be repeated to add more sources. The new modifier is a regular update context modifier without any specific built-in codepath, making its handling a lot easier and cleaner, while also allowing any custom attraction force expression as well as customizing other parameters of the source in real time. Revamp the `force_field.rs` example to showcase this new modifier, and add a dedicated parameter tweaking panel to observe the effect of each parameter. Fix a panic in rendering code when no effect is present. This looks like a race condition; for now simply early out to prevent the panic. ```rust effects_meta.dr_indirect_bind_group.as_ref().unwrap() ```
djeedai
added
A - internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the built-in code and shader handling a fixed-size array of force field attractors/repulsors, and related types
ForceFieldSourceandForceFieldModifier. Replace them with a newConformToSphereModifierdescribing a single attractor/repulsor source, which can be repeated to add more sources. The new modifier is a regular update context modifier without any specific built-in codepath, making its handling a lot easier and cleaner, while also allowing any custom attraction force expression as well as customizing other parameters of the source in real time.Revamp the
force_field.rsexample to showcase this new modifier, and add a dedicated parameter tweaking panel to observe the effect of each parameter.Fix a panic in rendering code when no effect is present. This looks like a race condition; for now simply early out to prevent the panic.