Added search type property to ionicFilterBar scope #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to handle numbers or dates gracefully, they contain digits and have length undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I required a date and month picker in the search so extended the plugin. The factory IonicFilterBar has added the following searchType property which allows the HTML input element to have the type set. This can be configured from an angular controller as an option on the show() function. E.g:
I've run the karma unit tests which pass 11/11 and tested it on android/ios with several search inputs of different types inside one view, all seems ok. The component change is not supported on the favourites bar, let me know if you would like this too.