set up migration context directly #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it seems like the connection method `migration_context` was removed in Rails 7.2 or 7.2.1, so autofix was raising a NoMethodError. With this change (largely borrowed from the Combustion gem), it should be possible to create a MigrationContext on Rails 6 and 7, even if the connection object doesn't provide one directly.
indirect
force-pushed
the
migration-context-missing
branch
from
1d0e125
to
ce34310
Compare
|
Thanks - I’m running into the same issue you describe and your branch appears to fix it for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems like the connection method
migration_contextwas removed in Rails 7.2. As a result,--autofixraises a NoMethodError. With this change (largely borrowed from the Combustion gem), it should be possible to create a MigrationContext on Rails 6 and 7, even if the connection object doesn't provide one directly. At least, these changes work for me on Rails 7.2.