sign assembly with strong name

[rapottu]

Signing assembly with strong name

https://docs.microsoft.com/en-us/dotnet/standard/assembly/create-use-strong-named

Prometheus-netcore also uses strong name. It can be a complaince requirement in certain infrastructure

https://github.com/prometheus-net/prometheus-net/blob/master/Prometheus.NetCore/Prometheus.NetCore.csproj

[djluck]

I'm happy to accept the inclusion of a strongly-named assembly if it's possible to maintain the status quo (keep the weakly-named assembly) and introduce a new strongly-named package. As it stands, I believe this PR will only produce a strongly-named package.

[rapottu]

As of now, I have V3 version signed and not V2 as prometheus-netstandard isn't signed in those versions. When you say introduce a new strongly-named package, you want a completely new csproj and new package?

[djluck]

Yes please- I believe that's the normal way of implementing optional strongly-named versions of packages.

[djluck]

As a hint, you might be able to reuse the build configurations to define a new strongly-named v3 configuration

[rapottu]

I feel test-v2 needs to be updated since I am trying to add a new csproj. Not sure how the test is implemented but it will be great if you can take a look

[rapottu]

Test failures fixed

[djluck]

@rapottu sorry for ignoring this for so long but I've been busy. Can you confirm you actually have a requirement for strong naming? Reading up on this (it's been a long time since I've delved into the depths of strong names), it seems it's less important on .NET core- just want to check it's actually going to help someone out (like yourself).