Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

druntime: remove libunwind dependency and make execinfo optional (LDC upstream) #20758

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

JohanEngelen
Copy link
Contributor

Based on:

This removes the dependency on libunwind and makes DefaultTraceInfo smart enough to not strictly require execinfo.

Tested to work well with LDC and with DMD here: #20741. (this PR is pre-requisite of #20741)

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JohanEngelen! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20758"

@JohanEngelen JohanEngelen changed the title druntime: Upstream exception stack traces on musl platforms from LDC druntime: remove libunwind dependency and make execinfo optional (LDC upstream) Jan 22, 2025
@thewilsonator thewilsonator added the Druntime Specific to druntime label Jan 22, 2025
@thewilsonator thewilsonator merged commit 047dfb5 into dlang:master Jan 23, 2025
39 of 41 checks passed
@JohanEngelen JohanEngelen deleted the libunwind_removal branch January 23, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Druntime Specific to druntime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants