Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to disable ModuleInfo generation based upon import path #20947

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rikkimax
Copy link
Contributor

@rikkimax rikkimax commented Mar 4, 2025

Preference to merging should go to: #20899
I need it a lot more.

This is a preparation PR, to make ModuleInfo generation be dependent on the import path switch.

It is to help codebases that are mixed -betterC and full D.

See any of the bindbc codebases for why it is absolutely abhorrent that it is an all or nothing switch, rather than recognizing its pay as you go runtime scale nature.

https://github.com/BindBC/bindbc-sdl/blob/master/dub.json

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @rikkimax! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20947"

@rikkimax
Copy link
Contributor Author

rikkimax commented Mar 4, 2025

LINK : fatal error LNK1000: unknown error at 00007FF7B4E59F06; consult documentation for technical support options

Welp I haven't seen that one before

@rikkimax rikkimax force-pushed the add-disabling-moduleinfo branch from 4b9ce09 to 5bb2d38 Compare March 4, 2025 06:17
@rikkimax
Copy link
Contributor Author

rikkimax commented Mar 4, 2025

Or:

Error: error: git-remote-https died of signal 10
Error: fatal: remote helper 'https' aborted session

It really doesn't want to go in!

@rikkimax rikkimax force-pushed the add-disabling-moduleinfo branch from 5bb2d38 to 63a974a Compare March 4, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants