[fix][io] KCA: Option to use kafka connector's SourceConnector class to create task and task config #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
KCA's SourceConnector uses Kafka's task name as a parameter and creates the task directly.
this works well enough for simpler or old sources (e.g. deebzium's potgre/mysql/mongo etc).
Actual expected life cycle is to create a connector, then get the task class and the task config from it.
Connectors that rely on such cycle do not work with KCA, e.g. yugabyte's debezium source. See
https://apache-pulsar.slack.com/archives/C5Z4T36F7/p1677506713032549 for details.
Modifications
Added option to pass source connector's class name, made use of it.
Kept the KCA compatible with old configuration, falling back to the legacy behavior if the config is not set.
Verifying this change
This change added unit test.
Does this pull request potentially affect one of the following parts:
NO
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: