Emit newlines instead of \n in docstrings #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devurandom
force-pushed
the
ds/issue-111
branch
from
f8a7bb4 to
291c825
Compare
devurandom
commented
Aug 2, 2024
Comment on lines
+68
to
+70
| forwarded-meta (not-empty (into (sorted-map) (select-keys m [:doc :deprecated])))] | ||
| (list* 'defmacro (with-meta n forwarded-meta) |
There was a problem hiding this comment.
This was necessary, because defmacro docstrings were still printed the old way (with \n). With this change, they undergo the same DocString treatment as defn and ns.
|
This looks great. Do you know if we can combine this with pprinting the rest of the forms? |
How do you mean? Which forms should be pretty printed? |
devurandom
force-pushed
the
ds/issue-111
branch
from
291c825 to
7102925
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #111