-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IME input bug #718
Fix IME input bug #718
Conversation
(cherry picked from commit 0f3704e)
Thanks for your effort. |
Besides, what did you mean by |
I thought the problem was solved because I didn't know how to use the IME for that language and couldn't implement it. I just restored that part. |
I installed the Pinyin QQ input tool and did a quick test, and there was no problem, so I mentioned Chinese as well. It was a mistake. |
I have confirmed that full-width characters can be input with this modification. However, I could not confirm —— and … … because I do not know how to input them with the keyboard. |
Looks good to me. Thanks again! |
Fixes an issue where synchronization does not work properly when entering Korean or Chinese characters in the left or right text box.
[Before fixing]
[After fixing]
[fixing]
Here's where the problem starts:
3-1. When a complete character is entered, Korean commitString is uniquely entered as a blank space. This makes the code flow as if a string was entered but not entered.
3-2. Since input_method_used continues to be true, even if alphabets or numbers are entered, the previous commitString is repeated.
I think that fixing this issue will also solve the input issues like #76 #313 #647 #654.
I tried using the Pinyin QQ inputter to verify, but I couldn't implement the issue.
Additionally, when a character is not completed, drawing strokes or shadows does not work in real time. This is because Document.toPlainText() does not include preeditString . However, I do not know how to fix this cleanly.