feat: update minipool manager address for v1.3.1, get latest mp delegate ABI #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 81d74be): https://rocketsweep-prod--pr57-daniel-v131-contract-6tpvkv38.web.app (expires Tue, 03 Dec 2024 16:22:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: cbd563b87d039ec85d93a577fba3ca36b3c6968a |
dmccartney
commented
Nov 26, 2024
| @@ -43,6 +43,7 @@ const contracts = { | |||
| }, | |||
| RocketMinipoolManager: { | |||
| address: [ | |||
| "0xF82991Bd8976c243eB3b7CDDc52AB0Fc8dc1246C", | |||
There was a problem hiding this comment.
We detect a node's minipools by looking for MinipoolCreated events across all versions of the RocketMinipoolManager. So rocketsweep couldn't see saturn0 minipools because it didn't know to look at the new version of the manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #39 and fixes reports of post saturn0 minipools not showing up.