Use CMAKE_MSVC_RUNTIME_LIBRARY to consistently handle linking mode for MSVC runtime #687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Windows platform, the MSVC (Microsoft Visual C++) runtime can be linked either statically or dynamically. Currently, DMLC-Core makes this choice by manually editing raw build flags:
dmlc-core/CMakeLists.txt
Lines 200 to 211 in 1ef6649
This approach is brittle and prone to errors.
A more robust method is to use the built-in flag
CMAKE_MSVC_RUNTIME_LIBRARY
to control the linking mode for the MSVC runtime.