-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dask] Sort and partition for ranking. #11007
Open
trivialfis
wants to merge
11
commits into
dmlc:master
Choose a base branch
from
trivialfis:dask-sort-qid-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
force-pushed
the
dask-sort-qid-1
branch
4 times, most recently
from
November 21, 2024 15:36
c1195a7
to
dc1397f
Compare
- Implement automatic local sort. - Implement partitioning by query ID. - Document for distributed ranking.
trivialfis
force-pushed
the
dask-sort-qid-1
branch
from
November 22, 2024 07:24
f17cf14
to
46b5d23
Compare
trivialfis
changed the title
[WIP][Dask] Sort within worker for ranking.
[Dask] Sort within worker for ranking.
Nov 22, 2024
trivialfis
changed the title
[Dask] Sort within worker for ranking.
[Dask] Sort and partition for ranking.
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the changes in the tutorial about the new features. In summary, we can now have two different ways to handle query groups in the Dask interface, depending on whether a global sort is desired.
Please note that, this PR ensures the accuracy of the model at a heavy performance price. A global sort is costly and pushing huge amount of small partitions into the
QuantileDMatrix
is also inefficient.related:
DMatrix
constructors? XGBoost.jl#160