Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] [py] Drop support for datatable. #11070

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Dec 7, 2024

Related microsoft/LightGBM#6662 .

Not to be confused with the R data.table, this is the Python version.

cc @jameslamb

We are working on auto re-coding for categorical features with dataframe inputs, it's unlikely that we will have the same treatment for datatable. It's better to remove it so that we can have consistent behaviors across all dataframe implementations.

@trivialfis trivialfis changed the title Drop support for datatable. [breaking] [py] Drop support for datatable. Dec 7, 2024
Copy link
Contributor

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I think it's a good time for this, for all the reasons mentioned in that LightGBM issues you linked to.

I did this just to check:

git grep -i -E 'datatable|h2o'

I see a few other uses that should be removed:

datatable = ["datatable"]

def no_dt() -> PytestSkip:
return no_mod("datatable")

| datatable.Frame | T | FF | | NPA | FF | |
+-------------------------+-----------+-------------------+-----------+-----------+--------------------+-------------+
| datatable.Table | T | FF | | NPA | FF | |

@trivialfis
Copy link
Member Author

Yup, will prune all the related code and references.

@trivialfis trivialfis requested review from jameslamb and hcho3 and removed request for jameslamb December 8, 2024 07:32
@trivialfis
Copy link
Member Author

Will merge if there's no objection.

@trivialfis trivialfis merged commit a361896 into dmlc:master Dec 9, 2024
68 of 72 checks passed
@trivialfis trivialfis deleted the drop-dt branch December 9, 2024 12:59
david-cortes pushed a commit to david-cortes/xgboost that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants