Add save_raw method to XGBModel
#9451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
reviewed
Aug 9, 2023
| digits = load_digits(n_class=2) | ||
| y = digits['target'] | ||
| X = digits['data'] | ||
| kf = KFold(n_splits=2, shuffle=True, random_state=rng) |
There was a problem hiding this comment.
Considering this is model IO, maybe we can use a lighter-weight test without grid search and with early stopping enabled so that the test can cover more IO-related features in a more efficient way?
There was a problem hiding this comment.
Yeah, that's fair. I'd just copy pasta'd the tests for save_model. I'll look at simplifying this when I get a chance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was missing from
XGBModelbut would be very useful.