[R] Fix method name. #9577
Merged
[R] Fix method name. #9577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-devel think this is an unregistered s3 method. ``` Mismatches for apparent methods not registered: format: function(x, ...) format.eval.string: function(iter, eval_res, eval_err) See section ‘Registering S3 methods’ in the ‘Writing R Extensions’ manual. ```
|
cc @jameslamb |
|
We faced this in LightGBM's last attempt to release to CRAN too: microsoft/LightGBM#5988 Sorry, I should have come and checked for it here. By the way, if CRAN also complains about tests and examples using too many threads, you might find these links useful: microsoft/LightGBM#5987 |
jameslamb
approved these changes
Sep 13, 2023
|
Thank you for sharing and the suggestions!
I will make the change, anything that makes the code better. |
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Sep 18, 2023
trivialfis
added a commit
that referenced
this pull request
Sep 18, 2023
Closed
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r-devel thinks this is an unregistered s3 method.