Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] Use inplace predict #9829
[R] Use inplace predict #9829
Changes from 26 commits
2471933
b605ef7
af81946
5b8c661
080f372
d1fdac0
bd62c5b
9a19e3d
d07162b
dea90b0
9347a41
248204c
f6cd2db
d824ff4
50811c3
7a775d0
2b32b4f
8584093
5fec492
5b045ba
4f07239
218c3db
b999c2a
afde244
e03527c
16cb633
97e7e76
b7ca893
9609b61
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually use
nan
as missing value, since XGBoost can handle 0 just as any other real number.This is also a headache for us since many sparse matrix implementations assume 0 as missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, default value is R's
NA
, which gets translated to eitherNAN
orR_NaInt
depending on the input type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to support leaf in the near future.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.