reduce unnecessary logging

dmowcomber · Aug 8, 2024 · c645d31 · c645d31
1 parent b5e4089
commit c645d31
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 21 deletions.
diff --git a/rail/track.go b/rail/track.go
@@ -3,7 +3,6 @@ package rail
 import (
 	"errors"
 	"io"
-	"log"
 	"sort"
 	"sync"
 	"time"
@@ -121,7 +120,7 @@ func (t *Track) write(data []byte) error {
 	defer func() {
 		serialWriteLatency.Observe(time.Since(start).Seconds())
 	}()
-	log.Printf("writing data: %s\n", data)
+	// log.Printf("writing data: %s\n", data)
 	_, err := t.serial.Write(data)
 	if err != nil {
 		return err

diff --git a/throttle/throttle.go b/throttle/throttle.go
@@ -157,7 +157,7 @@ func (t *Throttle) write(data []byte) error {
 	if t.serial == nil {
 		return errors.New("serial writer has not been initialized")
 	}
-	log.Printf("writing data: %s\n", data)
+	// log.Printf("writing data: %s\n", data)
 	_, err := t.serial.Write(data)
 	if err != nil {
 		return err

diff --git a/ui/api/state.go b/ui/api/state.go
@@ -26,9 +26,7 @@ func (a *API) stateHandler(w http.ResponseWriter, r *http.Request) {
 		fmt.Fprintf(w, `{"error":"%s"}`, err.Error())
 		return
 	}
-	fmt.Println(resp)
 	w.WriteHeader(http.StatusOK)
-	fmt.Printf("writing data: %s\n", string(data))
 	w.Write(data)
 }
 

diff --git a/ui/cli/cli.go b/ui/cli/cli.go
@@ -39,43 +39,46 @@ func (c *CLI) Run() error {
 
 		switch char {
 		case 'p':
-			c.track.PowerToggle()
+			_, err = c.track.PowerToggle()
 		case 's':
-			c.throt.Stop()
+			err = c.throt.Stop()
 		case '0':
-			c.throt.ToggleFunction(0)
+			_, err = c.throt.ToggleFunction(0)
 		case '1':
-			c.throt.ToggleFunction(1)
+			_, err = c.throt.ToggleFunction(1)
 		case '2', 'h':
-			c.throt.ToggleFunction(2)
+			_, err = c.throt.ToggleFunction(2)
 		case '3':
-			c.throt.ToggleFunction(3)
+			_, err = c.throt.ToggleFunction(3)
 		case '4':
-			c.throt.ToggleFunction(4)
+			_, err = c.throt.ToggleFunction(4)
 		case '5':
-			c.throt.ToggleFunction(5)
+			_, err = c.throt.ToggleFunction(5)
 		case '6':
-			c.throt.ToggleFunction(6)
+			_, err = c.throt.ToggleFunction(6)
 		case '7':
-			c.throt.ToggleFunction(7)
+			_, err = c.throt.ToggleFunction(7)
 		case '8', 'm':
-			c.throt.ToggleFunction(8)
+			_, err = c.throt.ToggleFunction(8)
 		case '9':
-			c.throt.ToggleFunction(9)
+			_, err = c.throt.ToggleFunction(9)
 		default:
 			if key == keyboard.KeyArrowUp {
-				c.throt.ThrottleUp()
+				err = c.throt.ThrottleUp()
 			} else if key == keyboard.KeyArrowDown {
-				c.throt.ThrottleDown()
+				err = c.throt.ThrottleDown()
 			} else if key == keyboard.KeyArrowRight {
-				c.throt.DirectionForward()
+				err = c.throt.DirectionForward()
 			} else if key == keyboard.KeyArrowLeft {
-				c.throt.DirectionBackward()
+				err = c.throt.DirectionBackward()
 			} else if key == keyboard.KeyCtrlC {
 				return nil
 			} else {
 				// TODO: print usage
 			}
 		}
+		if err != nil {
+			log.Print(err.Error())
+		}
 	}
 }