Feature/16 save extra report notes #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivellios
approved these changes
Oct 16, 2020
ivellios
requested changes
Nov 14, 2020
| @@ -45,6 +45,7 @@ class Meta: | |||
| "date", | |||
| "table_name", | |||
| "table_extra_notes", | |||
| "report_notes", | |||
There was a problem hiding this comment.
This does not fully cover requirement on who can see the report.
Anyone with access to this endpoint can pull the data and read the notes. It should be returned as a null or empty string, if the requesting user is not a DM. So we need a backend to check access to the field. This can be easily covered with MethodField.
There was a problem hiding this comment.
Thanks for the info. I added check in the serializer.
ivellios
requested changes
Nov 21, 2020
| @@ -64,6 +65,11 @@ def get_time_start(self, game): | |||
| def get_time_end(self, game): | |||
| return game.time_end.strftime("%H:%M") if game.time_end else "" | |||
|
|
|||
| def get_report_notes(self, game): | |||
| if self.context["request"].user.profile != game.dm: | |||
There was a problem hiding this comment.
Actually it should be visible to ANY DM in the system, so the role of the profile should be checked. AFAIR there's a method/property for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added saving report extra notes via api ( #16 )
Not sure if this is the refactoring you had in mind. Let me know if I should add some tests.
To be merged after #22