[Feat/#-] 기획 사항을 고려하여 기능 구현 및 리팩토링 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests and responses
Starlight258
changed the title
FacerAin
approved these changes
Feb 21, 2024
| prefix = "-"; | ||
| } | ||
| return prefix + String.format("%02d:%02d", hours, minutes); | ||
| long seconds = duration.abs().getSeconds(); |
There was a problem hiding this comment.
abs 처리해서 포맷에 +/- 안 붙게 하신 점 좋습니다!
| @@ -50,14 +51,21 @@ public class Member extends BaseEntity { | |||
| @OneToMany(mappedBy = "member", fetch = FetchType.EAGER) | |||
| private Set<Participant> participations = new HashSet<>(); | |||
|
|
|||
| // MEMO : 필수값들이므로 final 붙임 | |||
| @Column(nullable = false, name = "image_num") | |||
| private Long imageNum = new Random().nextLong(12) + 1; | |||
There was a problem hiding this comment.
P3: 사소하지만, imageNum의 경우 숫자 표현의 범위가 크지 않을 것 같아 integer로 처리해도 좋을 것 같아요 👍
There was a problem hiding this comment.
동감합니다! 타입 바꿔서 커밋 올렸어요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
🛠 개발 기능
🔍 리뷰 포인트
📋 Code Review Priority Guideline