Feat: 테스트 격리성 개선 및 WithMockCustomUser 어노테이션 제거 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FacerAin
approved these changes
Mar 17, 2024
| Member member = createTestMember(); | ||
| UserDetails userDetails = new CustomUserDetails(member); | ||
| Authentication auth = new UsernamePasswordAuthenticationToken(userDetails, null, userDetails.getAuthorities()); | ||
| SecurityContextHolder.getContext().setAuthentication(auth); |
There was a problem hiding this comment.
Security Context Holder를 통해 JWT 관련 Test를 가능하게 한점 좋습니다 👍👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
🛠 개발 기능
createTestMeeting과createTestMember메소드를 추가@BeforeEach로 테스트 데이터 준비 및@AfterEach로 테스트 데이터 제거@BeforeEach에 보안 컨텍스트 설정@WithMockCustomUser제거🧩 해결 방법
데이터 의존성을 줄인 테스트 코드 작성
🔍 리뷰 포인트
보안 컨텍스트를 직접 설정하여 문제를 해결했어요.테스트 데이터를 직접 생성하고 제거하는 식으로 의존성을 해결했어요.📋 Code Review Priority Guideline