refactor(ui/system): createContext 함수의 인자를 간략화, 반환값 Provider, useContext이 포함된 배열로 변경 #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
refactor
sukvvon
commented
Aug 21, 2024
Comment on lines
-8
to
+12
| type CreatContextOptions<T> = { | ||
| name?: string; | ||
| hookName?: string; | ||
| providerName?: string; | ||
| errorMessage?: string; | ||
| defaultValue?: T; | ||
| }; | ||
|
|
||
| type CreateContextReturn<T> = [Provider<T>, () => T, Context<T>]; | ||
| export function createContext<T extends object | null>( | ||
| rootComponentName: string, | ||
| defaultValue?: T, | ||
| ) { | ||
| const Context = createReactContext<T | undefined>(defaultValue); |
There was a problem hiding this comment.
기존 name, hookName이 포함된 객체 인자를 제거하고 rootComponentName, defaultValue로 인자를 간략화합니다.
Comment on lines
+17
to
+18
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| const value = useMemo(() => context, Object.values(context)) as T; |
There was a problem hiding this comment.
useMemo를 사용하여 context의 값들이 변경되었을 때만 재생성하게 하여 재렌더링을 방지합니다.
Comment on lines
+14
to
+23
| function Provider(props: T & { children: ReactNode }) { | ||
| const { children, ...context } = props; | ||
|
|
||
| export function createContext<T>(options: CreatContextOptions<T>) { | ||
| const { | ||
| name, | ||
| hookName = 'useContext', | ||
| providerName = 'Provider', | ||
| errorMessage, | ||
| defaultValue, | ||
| } = options; | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| const value = useMemo(() => context, Object.values(context)) as T; | ||
|
|
||
| const Context = createReactContext<T | undefined>(defaultValue); | ||
| return <Context.Provider value={value}>{children}</Context.Provider>; | ||
| } | ||
|
|
||
| Context.displayName = name; | ||
| Provider.displayName = rootComponentName + 'Provider'; |
There was a problem hiding this comment.
Provider를 컴포넌트처럼 사용할 수 있게 변경합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
작업한 목록을 작성해 주세요
스크린샷
pr 포인트나 궁금한 점을 작성해 주세요