refactor(ui/hooks): useControllableState 내부 type 명확화, value 관련 명칭 state로 수정 #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
refactor
sukvvon
commented
Aug 22, 2024
Comment on lines
+20
to
+22
| const [uncontrolledProp, setUncontrolledProp] = useState<T | undefined>( | ||
| defaultProp, | ||
| ); |
There was a problem hiding this comment.
setState 내부 setUncontrolledProp이 쓰이므로 useState의 generic에 타입을 명시합니다(T | undefined).
Comment on lines
+24
to
-29
| const state = isControlled ? prop : uncontrolledProp; | ||
| const handleChange = useCallbackRef(onChange); | ||
| const shouldUpdateProp = useCallbackRef(shouldUpdate); | ||
|
|
||
| const [uncontrolledValue, setUncontrolledValue] = useState(defaultValue as T); | ||
| const isControlled = valueProp !== undefined; | ||
| const value = isControlled ? valueProp : uncontrolledValue; |
There was a problem hiding this comment.
기존 값을 의미하는 value에서 어떤 상태가 올지 모르기 때문에 명확히 하기 위해 상태를 의미하는 state로 명칭을 변경합니다.
|
|
||
| const setValue: Dispatch<SetStateAction<T>> = useCallback( | ||
| const setState: Dispatch<SetStateAction<T | undefined>> = useCallback( |
There was a problem hiding this comment.
기존 값을 의미하는 value에서 어떤 상태가 올지 모르기 때문에 명확히 하기 위해 상태를 의미하는 state로 명칭을 변경합니다.
마찬가지로 setValue에서 setState로 명칭을 변경합니다.
|
|
||
| handleChange(nextValue); | ||
| handleChange(nextState as T); |
There was a problem hiding this comment.
nextValue는 항상 undefined가 아닌 값이 오기 때문에 T로 단언합니다.
const [state = false, setState] = useControllableState({
prop: undefined,
defaultProp: undefined,
onChange: undefined,
});
setState((prevState = false) => !prevState);
setState(!state);위와 같이 T가 boolean이고 모든 useControllableState에 들어가는 값들이 undefined인 경우를 예시로 들면 항상 prevState는 undefined일 경우 false와 같이 정의해야만 typescript에서 오류가 발생하지 않습니다. 또한 state를 이미 false와 같은 값으로 지정하였기 때문에 !state를 해도 안전하게 동작합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
작업한 목록을 작성해 주세요
스크린샷
pr 포인트나 궁금한 점을 작성해 주세요