Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web/components): Error, react-query가 포함된 ErrorBoundary 컴포넌트 추가 #42

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

sukvvon
Copy link
Member

@sukvvon sukvvon commented Feb 14, 2024

이슈 번호

작업한 목록을 작성해 주세요

스크린샷

pr 포인트나 궁금한 점을 작성해 주세요

  • Error 컴포넌트는 임시로 제작을 하였습니다!
  • vanilla-extract를 사용하여 컴포넌트를 제작할 때 어떤 스타일로 할지 고려하였습니다!

@sukvvon sukvvon linked an issue Feb 14, 2024 that may be closed by this pull request
2 tasks
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
favolink-web ✅ Ready (Inspect) Visit Preview Feb 14, 2024 5:37am

@github-actions github-actions bot added chore 빌드 프로세스나 패키지 매니징과 같은 일상적인 업무나 유지보수 작업(빌드 시스템, 도구, 환경 설정 등) feat 새로운 기능 추가 또는 기존 기능의 확장 labels Feb 14, 2024
Copy link

Thanks for the contribution!
I have applied any labels matching special text in your title and description.

Please review the labels and make any necessary changes.

import { style } from '@vanilla-extract/css';

export const container = style({
height: '100vh',
Copy link
Member

@heyman333 heyman333 Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@supports (height: 100dvh) {
      height: 100dvh;
}

dvh 써봐도 괜찮을거같아요!

Copy link
Member Author

@sukvvon sukvvon Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음 pr에 참고하겠습니다!! 👍

Copy link
Member

@heyman333 heyman333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨오요!

@sukvvon sukvvon merged commit 5856938 into main Feb 15, 2024
6 checks passed
@sukvvon sukvvon deleted the feat/34 branch February 15, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 빌드 프로세스나 패키지 매니징과 같은 일상적인 업무나 유지보수 작업(빌드 시스템, 도구, 환경 설정 등) feat 새로운 기능 추가 또는 기존 기능의 확장
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(web): Error, react-query가 포함된 ErrorBoundary 컴포넌트 추가
2 participants