-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web, shared/utils): Portal, Modal 컴포넌트, useDisclosure 훅, classNames 유틸 생성 #55
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
export const overlay = styleVariants({ | ||
original: [ | ||
baseOverlay, | ||
{ backgroundColor: 'rgba(0, 0, 0, 0.5)', zIndex: 96 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
z-index는 따로 상수로 관리해도 좋을거같은데 96으로 하신 이유가 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
우선 96이라는 숫자에 큰 의미는 없습니다!
상수로 관리한다는 말씀이 쓰이는 z-index마다 숫자가 아닌 상수 자체로 우선순위를 파악한다는 말씀이신가요?? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 파일 한곳에서 모아두면 나중에 겹치는 일이 없을거같아서요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍👍👍
이슈 번호
작업한 목록을 작성해 주세요
스크린샷
2024-02-22.5.14.45.mov
pr 포인트나 궁금한 점을 작성해 주세요
Modal 예제 코드