[feat #134] 채팅 요청 자동 거절 스케줄러 #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
Code Coverage
|
Test Results 25 files 25 suites 16s ⏱️ Results for commit 1320537. ♻️ This comment has been updated with latest results. |
dudxo
approved these changes
Oct 17, 2024
| .where(member.id.in(memberIds)) | ||
| .execute(); | ||
| } | ||
|
|
There was a problem hiding this comment.
updateChatRoomStatusRejected(), refundInMemberIds()을 호출하는 상위 메서드 ChatScheduler.rejectChatRequest()에 트랜잭션이 생성되어 있는데 한번 더 붙이셨네요?
중복인것 같습니다!
There was a problem hiding this comment.
제가 잘못 이해(?)한 내용일 수 있는데 틀리다면 말씀 부탁드립니다..!
There was a problem hiding this comment.
bulk update를 하는 repository 함수라서 transactional을 걸고,
scheduler에서 하나라도 잘못 되면 rollback하기 위해 transactional을 걸었습니다..!
scheduler 메서드에 해당 어노테이션을 거는게 맞는지 더 고민해봐야겠네요,,,
| .select(chatRoom.inquirer.id) | ||
| .from(chatRoom) | ||
| .where( | ||
| chatRoom.createdAt.loe(LocalDateTime.now().minusWeeks(1)), |
There was a problem hiding this comment.
loe 문법을 잘 몰라서 찾아보니 less than or equal 약어군요?
하나 배워갑니다..!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
📑 작업 상세 내용
💫 작업 요약
🔍 중점적으로 리뷰 할 부분